This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit/testsuite] dw2-const.S: fix type reference size on 64bit platforms.


Joel Brobecker wrote:
Hello,

The testcase was failing on various 64bit platforms, because the
debugging info said that the target type for a const type is a
4-byte reference.  In the asm file, I used a .long directive, but
the size of .long is of course dependent on the platform.  This
replaces this .long by a .4byte directive.

(observed on ia64-linux and mips-irix, for instance).

gdb/testsuite/ChangeLog:

        * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
        type of our const type.

Tested on x86_64-linux, and checked in.

---
 gdb/testsuite/ChangeLog              |    5 +++++
 gdb/testsuite/gdb.dwarf2/dw2-const.S |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 7b4b6a5..5d04cd9 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-22 Joel Brobecker <brobecker@adacore.com>
+
+ * gdb.dwarf2/dw2-const.S: Use .4byte to reference the target
+ type of our const type.
+
2010-09-22 Sami Wagiaalla <swagiaal@redhat.com>
* gdb.cp/pr12028.cc: New.
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-const.S b/gdb/testsuite/gdb.dwarf2/dw2-const.S
index f5c64f9..aa91839 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-const.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-const.S
@@ -55,7 +55,7 @@ func_cu1:
.Ltype_const:
.uleb128 0x9 /* Abbrev: DW_TAG_const_type */
- .long .Ltype_int-.Lcu1_begin /* DW_AT_type */
+ .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */

Any reason not to preserve the columnar alignment?



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]