This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING]RE: [RFA] Fix maint translate command
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: 'Pedro Alves' <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 22 Sep 2010 10:01:11 -0700
- Subject: Re: [PING]RE: [RFA] Fix maint translate command
- References: <002101cb49b3$50d60cd0$f2822670$@muller@ics-cnrs.unistra.fr> <000001cb49dc$81074080$8315c180$@muller@ics-cnrs.unistra.fr> <201009011625.27952.pedro@codesourcery.com> <201009011707.14802.pedro@codesourcery.com> <001201cb53e4$3c294e60$b47beb20$@muller@ics-cnrs.unistra.fr>
On Tue, Sep 14, 2010 at 10:10:02AM +0200, Pierre Muller wrote:
> The problem of break inside ALL_OBJSECTIONS
> is still not fixed on CVS despite a fix proposed by Pedro?
>
> I must confess that I am unable to fully understand such complicated
> macros, and I leave to others the responsibility to
> approve such kind of patches (I don't have any rights on
> objfiles sources anyhow ...)
>
> Would it be possible to check Pedro's patch in?
Seems like everyone is really really busy these days :-(.
This is coming from Pedro, and I didn't see anything wrong with it.
Since we haven't received any objection, I think it is fine to commit
after running it against the testsuite.
> > > I admit it loop ugly, and that may look complicated, but it isn't
> > > (complicated). The outer loop learns about the inner loop's end
> > > condition, and stops iterating if it detects the inner loop didn't
> > > reach it's end. The trick to not clearing "objfile" is to only
> > > advance it in the outer loop, if the inner loop reached it's end.
I think that this is a useful comment to add to the macro. And perhaps
explain that the purpose is to allow `break' to exit the ALL_OBJSECTIONS
(double-) loop.
--
Joel