This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: Your INTERMEDIATE_ENCODING patch for Solaris
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Tom Tromey'" <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 15 Sep 2010 11:57:24 +0200
- Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris
- References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <m37hk4x5r0.fsf@fleche.redhat.com> <m3eidxi069.fsf@fleche.redhat.com> <20100817184407.GC3599@adacore.com> <m3aaolgj0g.fsf@fleche.redhat.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <m38w43dho9.fsf@fleche.redhat.com> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <m34oeq8u1g.fsf@fleche.redhat.com> <m339twkmj5.fsf@fleche.redhat.com> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <m3k4n6hgqe.fsf@fleche.redhat.com> <44796.6229789474$1283326243@news.gmane.org> <m362yp9kaj.fsf@fleche.redhat.com> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> <m362yo88fj.fsf@fleche.redhat.com> <m3hbhs59iu.fsf@fleche.redhat.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: Tuesday, September 14, 2010 10:57 PM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: Your INTERMEDIATE_ENCODING patch for Solaris
>
> >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>
> Pierre> Probably just define PHONY_ICONV if the first set of conditions
> is
> Pierre> not met (by the way, I am not sure the libiconv version test
> Pierre> that we added is really pertinent.)
>
> Tom> Thanks. I think I got the logic wrong:
>
> Tom> +/* If we got here and have wchar_t support, we might be on a
> system
> Tom> + with some problem. So, we just disable everything. */
> Tom> +#if !(defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC))
> Tom> +#define PHONY_ICONV
> Tom> +#endif
>
> Tom> I think that "!" is wrong -- it even contradicts the comment.
> Tom> I'm sorry to keep bothering you about this, but could you remove
> that
> Tom> "!" and try again?
>
> Any word on this?
> I would like to commit this patch if it seems ok.
I can at least confirm that for
Sparc OpenSolaris 5.11 snv_111b it does
disable use of iconv functions from libc.so.1
So, at least for me, this should be modified
that way.
Pierre