This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache]

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> Too much indentation here.

Tom> Since psymbol_bcache is only used in psymtab.c, the definition should be
Tom> moved there, leaving just a forward declaration of the tag in psymtab.h.
Tom> This makes the type opaque, which is generally better.

I forgot to mention -- this is ok with those 2 changes.  Thanks again.


Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]