This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/9]#2 Split print_stop_reason into 5 funcs


On Monday 30 August 2010 08:11:18, Jan Kratochvil wrote:

> applicable independently.

Agreed.  This is okay.

> -/* Print why the inferior has stopped. We always print something when
> -   the inferior exits, or receives a signal. The rest of the cases are
> -   dealt with later on in normal_stop() and print_it_typical().  Ideally
> -   there should be a call to this function from handle_inferior_event()
> -   each time stop_stepping() is called.*/
> +/* Several print_*_reason functions to print why the inferior has stopped.
> +   We always print something when the inferior exits, or receives a signal.
> +   The rest of the cases are dealt with later on in normal_stop() and
> +   print_it_typical().  Ideally there should be a call to this function from
                                                     ^^^^^^^^^^^^^^^^^^^^^

needs adjustment


> +   handle_inferior_event() each time stop_stepping() is called.*/

Might as well fix the missing spaces   ---------------------------^
[I'd take the opportunity to remove the '()'s above as well.]


-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]