This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Delayed physnames, revisited


On Thu, Aug 19, 2010 at 12:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Sorry about the long delay on this.
> Please ping patches regularly, it helps embarrass us into responding ;-)
>
> Keith> I have finally gotten around to revisiting this patch and rebasing it
> Keith> on top of all the recent churn in dwarf2read.c. I have also (finally)
> Keith> developed a test case for the "trivial" obstack leak that I previously
> Keith> reported. [It was trivial, but also very dependent on compiler and STL
> Keith> implementation. That made it very non-trivial. :-)]
>
> This patch is ok. ?Thanks.

Not to nitpick or anything,
Well, yes to nitpick ... :-)

Folks are great at enforcing things like putting a space after the
function name in a function call, but not so good at enforcing having
a blank line between a function's comment and definition.

Keith, can you fix that?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]