This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Use custom hash function with bcache


1) We store symbol names such that we can compare them with ptr1 ==
ptr2, but your patch uses strcmp.

that explains how the old hash function worked :)

2) I'm wondering if there's some abstraction violation with bcache not
being aware of the extra memory that is used by
gsymbol->language_specific.cplus_specific.  Dunno, just wondering.

I think it is okay as long as the part of psymbol taken into consideration ensures that duplicate symbols are caught (Daniel had some comments here). Also, this is only for psymbols. Other clients still use the old hash function

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]