This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb
> Date: Mon, 16 Aug 2010 23:39:21 +0800
> From: "Yao Qi" <yao@codesourcery.com>
>
> > > >
> > > > Can you use func_loopfb instead of func_loopfb_start in the .S file?
> > > > Or, can you define func_loopfb_start as asm ("func_loopfb_start =
> > > > func_loopfb")?
> > > >
> > > > A third option is to address Mark's concern by using ".p2align 4"; I
> > > > believe that is 16-byte alignment on all platforms gas supports, and
> > > > this test probably requires gas in practice already.
> > >
> > > Yeah, update my patch by replacing '.align 2' with '.p2align 4'.
> > > Is that OK?
> >
> > Looks fine to me. Mark, what do you think?
>
> Mark,
> Is this patch OK to you?
Sorry, I though I replied to Daniel's message.
Anyway, I'm afraid I don't understand the problem you're trying to
fix, so it's hard to say for me that the diff is ok. However, I'd say
that 32-bit alignment should be enough; I don't know any architectures
that have instructions longer than 32-bits and care about alignment.