This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb

> > > 
> > > Can you use func_loopfb instead of func_loopfb_start in the .S file?
> > > Or, can you define func_loopfb_start as asm ("func_loopfb_start =
> > > func_loopfb")?
> > > 
> > > A third option is to address Mark's concern by using ".p2align 4"; I
> > > believe that is 16-byte alignment on all platforms gas supports, and
> > > this test probably requires gas in practice already.
> > 
> > Yeah, update my patch by replacing '.align 2' with '.p2align 4'.
> > Is that OK?
> 
> Looks fine to me.  Mark, what do you think?

Mark,
Is this patch OK to you?

-- 
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]