This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch for crash in d-lang.c's demangler


On Tue, 10 Aug 2010, Tom Tromey wrote:

> >>>>> "Brad" == Brad Roberts <braddr@puremagic.com> writes:
> 
> I think your patch is reasonable, but the line just after your change is
> weird:
> 
> >        if (i <= 0  && strlen (mangled_str) < i)
> >          return 0;
> 
> I don't think that condition can ever be true.

Agreed.  Your patch looks good.  I feel guilty about not contributing a 
unit test to cover this case, so I shouldn't poke you about not adding one 
either, but if you feel like feeling that guilty... :)

Thanks,
Brad


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]