This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Oleg Nesterov] PATCH? gdb remote.c: readchar() should pop_target() if SERIAL_ERROR?
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 28 Jul 2010 11:28:28 -0600
- Subject: Re: [Oleg Nesterov] PATCH? gdb remote.c: readchar() should pop_target() if SERIAL_ERROR?
- References: <m3fwzs1l8r.fsf@fleche.redhat.com> <4C4F55AE.4010507@vmware.com>
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> Tom Tromey wrote:
>> I am forwarding this from the archer list because I think this report is
>> reasonably complete -- I couldn't really improve on it.
>>
>> Please comment on this patch. I don't know this area of gdb well.
>>
>> If the enclosed has insufficient information, please contact me and I
>> will get whatever is needed. Thanks.
Michael> I'm sorry I haven't been able to recall how I've encountered this
Michael> symptom, so I can't provide a meaningful review.
Michael> Is there a chance of getting this into the 7.2 release?
The change seems correct to me, and I'm interested in getting it in.
But since I don't know this code well I am reluctant to commit it
without someone else's ok. If that isn't forthcoming I will try to look
into the code more deeply and see if I can figure it out. Maybe I can
do some kind of failure injection to see the bug live.
Tom