This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MAINTAINERS: Add myself for write after approval privileges.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Cheng Renquan <crquan at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 27 Jul 2010 21:17:24 -0700
- Subject: Re: MAINTAINERS: Add myself for write after approval privileges.
- References: <AANLkTinV9L3Yx1unbsnmMpvr+mXaiDMY_R2X28vPhzrF@mail.gmail.com>
> add-myself-for-write-after-approval-privileges.patch
>
> To Joel, sorry to mess things up again,
Not to worry. Welcome to the project.
I don't remember if I said this explicitly in my other email, but obvious
patches do not require approval before being checked in. I invite you
to have a look at the MAINTAINERS file again, if you are not familiar
with the "Obvious Fix Rule" and what constitutes an obvious fix and what
doesn't. It is always fine to err on the side of caution :).
That being said, you patch revealed that alphabetical order for
the write-after-approval list has been broken by the last couple of
entries. I fixed that, but you will need to redo your patch to insert
your name at the correct location. (no need to wait for approval, just
post the patch as usual, saying that you checked it in).
One last thing: Once you have checked in a patch that was approved,
can you send a followup email confirming the commit? It is customary
to do so and helps keeping track of which patches have been checked in
and which ones haven't.
--
Joel