This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix linux-nat.c {,lp->}status typo
On Tue, 20 Jul 2010 14:22:28 +0200, Pedro Alves wrote:
> On Sunday 18 July 2010 15:51:12, Jan Kratochvil wrote:
> In practice, status == lp->status at this point for !WIFSTOPPED,
> so there should be no impact.
You are right as I see now. OK, marked ChangeLog entry only as "Code cleanup".
> Okay, thanks.
Checked-in.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2010-07/msg00112.html
--- src/gdb/ChangeLog 2010/07/20 05:58:52 1.12000
+++ src/gdb/ChangeLog 2010/07/20 12:33:29 1.12001
@@ -1,3 +1,9 @@
+2010-07-20 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ Code cleanup.
+ * linux-nat.c (linux_nat_wait_1): Reset STATUS after calling
+ linux_nat_wait_1. Use always LP->STATUS afterwards.
+
2010-07-20 Hui Zhu <teawater@gmail.com>
* inf-ptrace.c (inf_ptrace_create_inferior): Initialize back_to.
--- src/gdb/linux-nat.c 2010/07/18 21:21:53 1.174
+++ src/gdb/linux-nat.c 2010/07/20 12:33:30 1.175
@@ -3367,6 +3367,9 @@
lp = linux_nat_filter_event (lwpid, status, options);
+ /* STATUS is now no longer valid, use LP->STATUS instead. */
+ status = 0;
+
if (lp
&& ptid_is_pid (ptid)
&& ptid_get_pid (lp->ptid) != ptid_get_pid (ptid))
@@ -3375,7 +3378,7 @@
if (debug_linux_nat)
fprintf (stderr, "LWP %ld got an event %06x, leaving pending.\n",
- ptid_get_lwp (lp->ptid), status);
+ ptid_get_lwp (lp->ptid), lp->status);
if (WIFSTOPPED (lp->status))
{
@@ -3412,7 +3415,7 @@
lp->signalled = 0;
}
}
- else if (WIFEXITED (status) || WIFSIGNALED (status))
+ else if (WIFEXITED (lp->status) || WIFSIGNALED (lp->status))
{
if (debug_linux_nat)
fprintf (stderr, "Process %ld exited while stopping LWPs\n",