This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: dan at codesourcery dot com
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 1 Jul 2010 18:10:21 +0200 (CEST)
- Subject: Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs
- References: <m31vboqh98.fsf@fleche.redhat.com> <20100701154058.GA25227@caradoc.them.org>
> Date: Thu, 1 Jul 2010 11:41:01 -0400
> From: Daniel Jacobowitz <dan@codesourcery.com>
>
> On Wed, Jun 30, 2010 at 04:37:23PM -0600, Tom Tromey wrote:
> > This patch changes dwarf2_frame_find_fde to check psymtabs_addrmap
> > before trying to read the FDE data.
> >
> > I am not totally convinced this is safe, so comments are especially
> > appreciated here.
>
> This doesn't sound right. I don't know how any of the psymtab changes
> work, but there shouldn't be a link between psymtabs and FDEs at all;
> they don't have to correspond. Wouldn't this break a library with
> .debug_frame for all code, and .debug_info for only one input object?
I agree with Daniel here.