This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Extend Fortran detection filename extensions


> > > +# Test automatic language detection before the inferior starts.
> > > +gdb_test "p modmany::var_i" " = 14" "stopped language detection"
> > 
> > Why not just do "show language"?
> 
> I believe this testcase should be in place as it tests it all together.
> 
> There could be probably also an isolated new testcase.  I was not sure if
> there would not be one day changes in how Fortran language variants get
> detected and called in `show language'.  But I understand in such case even
> the testcases must be changed.
> 
> Should I submit a separate testfile for it?

It's not very important, IMO. I'm happy with the above especially if
you adjust the comment to say that this *also* verifies that the language
is currently fortran, since the test itself seems to be important as well.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]