This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa] break.exp, send_gdb vs gdb_test
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 26 May 2010 11:16:52 -0700
- Subject: Re: [rfa] break.exp, send_gdb vs gdb_test
- References: <4BF85B9A.3020100@vmware.com>
> 2010-05-22 Michael Snyder <msnyder@vmware.com>
>
> * gdb.base/break.exp: Replace send_gdb with gdb_test.
This is OK, modulo the comment below.
> send_gdb "delete breakpoints\n"
> gdb_expect {
> - -re "Delete all breakpoints.*$" {
> - send_gdb "y\n"
> - gdb_expect {
> - -re "$gdb_prompt $" {
> - fail "Delete all breakpoints when none (unexpected prompt)"
> - }
> - timeout { fail "Delete all breakpoints when none (timeout after unexpected prompt)" }
> + -re "Delete all breakpoints.*$" {
> + send_gdb "y\n"
> + gdb_expect {
> + -re "$gdb_prompt $" {
> + fail "Delete all breakpoints when none (unexpected prompt)"
> }
> + timeout { fail "Delete all breakpoints when none (timeout after unexpected prompt)" }
> }
> - -re ".*$gdb_prompt $" { pass "Delete all breakpoints when none" }
> - timeout { fail "Delete all breakpoints when none (timeout)" }
> + }
> + -re ".*$gdb_prompt $" { pass "Delete all breakpoints when none" }
> + timeout { fail "Delete all breakpoints when none (timeout)" }
> }
This is pure reformatting as far as I can tell. Can you do that as
a separate patch?
--
Joel