This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFC: implement DW_OP_bit_piece

From: Stan Shebs <stan at codesourcery dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches at sourceware dot org, Jan Kratochvil <jkratoch at redhat dot com>
Date: Tue, 18 May 2010 16:50:42 -0700
Subject: Re: RFC: implement DW_OP_bit_piece
References: <m3ljbgdc4a.fsf@fleche.redhat.com>

Tom Tromey wrote:

I plan to check this in, but first I would appreciate comments on the
implementation.
This patch implements DW_OP_bit_piece. This is needed now that Jakub has pushed in gcc patches to generate it when SRA optimization is performed.

Your code looks reasonable, but you're missing two, uh, pieces :-) - the dwarf2_tracepoint_var_ref code to compile to bytecodes, and human-readable description in locexpr_describe_location_1.

(Yes it's onerous, but we did want to revive tracepoints, right?)

Stan

Follow-Ups:
- Re: RFC: implement DW_OP_bit_piece
  - From: Tom Tromey

References:
- RFC: implement DW_OP_bit_piece
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]