This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>, "'Tom Tromey'" <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 17 May 2010 19:33:57 +0200
- Subject: RE: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute
- References: <8830.7035308846$1273670829@news.gmane.org> <m34oibvhgh.fsf@fleche.redhat.com> <20100517172758.GJ2805@adacore.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé?: Monday, May 17, 2010 7:28 PM
> À?: Tom Tromey
> Cc?: Pierre Muller; gdb-patches@sourceware.org
> Objet?: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter
> attribute
>
> > Pierre> Should zero be considered as FALSE and
> > Pierre> thus the should say that this parameter is NOT a variable
> parameter,
> > Pierre> or does the simple presence of this attribute condfirm
> > Pierre> this it is a variable parameter, no matter the value of the
> flag.
> > Pierre> I took the first approach here, but have the impression
> > Pierre> that it is not always the case inside dwarf2read.c code.
> >
> > I think you made the correct choice.
>
> FWIW: I also double-checked the DWARF3 standard, and it says that the
> value of this attribute is a flag, and following the hyperlinks in
> the PDF, one gets to:
>
> flag
> A flag is represented as a single byte of data (DW_FORM_flag).
> If the flag has value zero, it indicates the absence of the
> attribute. If the flag has a non-zero value, it indicates the
> presence of the attribute.
So, may I commit this patch?
Pierre