This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ob] remote.c, eliminate unused variables

From: Michael Snyder <msnyder at vmware dot com>
To: "tromey at redhat dot com" <tromey at redhat dot com>
Cc: Pedro Alves <pedro at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Fri, 07 May 2010 11:51:23 -0700
Subject: Re: [ob] remote.c, eliminate unused variables
References: <4BE1D93F.8000309@vmware.com> <201005052151.19745.pedro@codesourcery.com> <4BE1DFA9.9060607@vmware.com> <201005052241.14753.pedro@codesourcery.com> <4BE1EF9C.8070807@vmware.com> <m31vdnhalv.fsf@fleche.redhat.com>

Tom Tromey wrote:

"Michael" == Michael Snyder <msnyder@vmware.com> writes:


Michael> No, I'm attempting to make the code easier to understand by
Michael> removing dead code and variables.  Since this warning is
Michael> turned off, I'm not even reducing the number of warnings.

Are you planning to enable them?  I hope so, since otherwise this work
will quickly regress.

I was, but there have been a handful of cases that I could not eliminate so far.


FWIW I read through all the patches and sent comments about the changes
I saw that seemed fishy.

Thanks, the review is much appreciated.

References:
- [ob] remote.c, eliminate unused variables
  - From: Michael Snyder
- Re: [ob] remote.c, eliminate unused variables
  - From: Pedro Alves
- Re: [ob] remote.c, eliminate unused variables
  - From: Michael Snyder
- Re: [ob] remote.c, eliminate unused variables
  - From: Pedro Alves
- Re: [ob] remote.c, eliminate unused variables
  - From: Michael Snyder
- Re: [ob] remote.c, eliminate unused variables
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]