This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> --- jv-lang.c	22 Apr 2010 23:15:41 -0000	1.83
>> +++ jv-lang.c	6 May 2010 23:35:37 -0000
>> @@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch
>> struct value *utf8_name;
>> char *nptr;
>> CORE_ADDR addr;
>> +#if 0
>> struct block *bl;
>> struct dict_iterator iter;
>> +#endif

Joel> Can you explain why using #if 0 instead of deleting these variables?

I looked at that, too.  There is (pseudo-)code that references these
variables, also in #if 0.

I think any code in jv-* that has been #if 0 for 10 years can be deleted
with no loss.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]