This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Michael Snyder <msnyder at vmware dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 07 May 2010 11:29:15 -0600
- Subject: Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
- References: <4BE35310.9020704@vmware.com> <20100507031644.GZ2768@adacore.com>
- Reply-to: tromey at redhat dot com
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> --- jv-lang.c 22 Apr 2010 23:15:41 -0000 1.83
>> +++ jv-lang.c 6 May 2010 23:35:37 -0000
>> @@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch
>> struct value *utf8_name;
>> char *nptr;
>> CORE_ADDR addr;
>> +#if 0
>> struct block *bl;
>> struct dict_iterator iter;
>> +#endif
Joel> Can you explain why using #if 0 instead of deleting these variables?
I looked at that, too. There is (pseudo-)code that references these
variables, also in #if 0.
I think any code in jv-* that has been #if 0 for 10 years can be deleted
with no loss.
Tom
- References:
- [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
- Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables