This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ARI] Remove all editCase warnings

From: Michael Snyder <msnyder at vmware dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
Date: Tue, 04 May 2010 16:51:41 -0700
Subject: Re: [ARI] Remove all editCase warnings
References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com>

Pedro Alves wrote:

On Wednesday 05 May 2010 00:25:48, Pierre Muller wrote:
ARI: Fix editCase.

        * remote.c (set_remote_protocol_Z_packet_cmd): Rename to...
        (set_remote_protocol_z_packet_cmd): ...this.
        (show_remote_protocol_Z_packet_cmd): Rename to...
        (show_remote_protocol_z_packet_cmd): ...this.
        (store_register_using_P): Rename to...
        (store_register_using_p): ...this.
        (store_register_using_G): Rename to...
        (store_register_using_g): ...this.
        (remote_store_registers): Adapt to name changes above.
        (watchpoint_to_Z_packet): Rename to...
        (watchpoint_to_z_packet): ...this.


I'd rather not.  Z, z, P, G, g, are all distinct packets, uppercase
having the opposite effect of lowercase.  Example, you really store
with G, not g, which is for fetches (note the `fetch_registers_using_g'
function).

I agree with Pedro and Stan.

References:
- [ARI] Remove all editCase warnings
  - From: Pierre Muller
- Re: [ARI] Remove all editCase warnings
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]