This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 3/3] bpstat_what removal


Jan Kratochvil wrote:
Hi,

the simple idea is to inline bpstat_what into handle_inferior_event. This
removes enum bpstat_what_main_action and struct bpstat_what currently acting
just as an interface between these two functions.
There's a reason for this actually, which is that it helps keep the myriad of random breakpoint types from infecting the rest of GDB. Breakpoint types are visible globally, and individual breakpoint types are mentioned here and there in the code, but I think it's worthwhile to keep the type enumerations / switches in breakpoint.c as much as possible.

There is a pretty good chance that we're going to be doing some refactoring on how breakpoint types are handled - people are interested in the idea of "tracing watchpoints" (or "watching tracepoints" :-) ) for instance - so there's a practical reason to provide interfaces that define the net effect of types, rather than requiring callers to know aracane details of each.

Stan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]