This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Richard Earnshaw <rearnsha at arm dot com>
- Cc: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>, gdb-patches at sourceware dot org
- Date: Mon, 3 May 2010 18:57:12 -0400
- Subject: Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
- References: <1272547868.19716.13.camel@e102111-lin.cambridge.arm.com> <1272548983.28096.23.camel@e102346-lin.cambridge.arm.com>
On Thu, Apr 29, 2010 at 02:49:43PM +0100, Richard Earnshaw wrote:
>
> On Thu, 2010-04-29 at 14:31 +0100, Matthew Gretton-Dann wrote:
> > Hi,
> >
> > Can someone please review and comment on the attached patch?
> >
> > The patch fixes support for longjmp on ARM Linux. Dependent on the FP
> > model in use the location of the PC to use as the long jump return value
> > is stored in different locations in the long jump buffer. Currently gdb
> > uses a hard-coded value which works for only one FP model, this patch
> > corrects this.
I'm not going to make a fuss, but for the record I am very weakly
opposed to this patch. The offset of PC in the longjmp buffer is
deliberately left implementation-private by the EABI. I'd rather we
got back to the generic (step-based or breakpoint-based rather than
jmp_buf-decoding-based) solution to longjmp.exp failures.
On the other hand, I can't see why this should hurt :-)
--
Daniel Jacobowitz
CodeSourcery