This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Observer mode


> Date: Thu, 29 Apr 2010 10:22:31 -0700
> From: Stan Shebs <stan@codesourcery.com>
> 
> + @node Observation Mode
> + @subsection Observation Mode

A suitable index entry would be good here.

> + When all of these are set to @code{off}, then @value{GDBN} is said
> + to be @dfn{observation mode}.

"in observation mode", I presume.

Also, the above sentence is ambiguous: it took me a while to
understand that "all of these" refer to the settings described in this
section.  Please say that explicitly.

> + combinations of these settings. For instance, if you have enabled
                                  ^^
Need two spaces here (and in a few other places in the patch).

> + @itemx set may-write-memory off
> + This controls whether @value{GDBN} will attempt to alter the contents
> + of memory, such as with assignment expressions in @code{print}.

This is also relevant to setting breakpoints, right?  If so, I suggest
to mention them.

> + Otherwise, any sort of write attempt will result in an error."),

Is this useful behavior?  I'd assume that setting these to off would
silently fail the operation.  Otherwise, how would these settings be
useful?  They exist to allow uninterrupted program run, don't they?

> + 	error ("No tracepoints downloaded, not starting trace");

No _() around a message here.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]