This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit/Ada] Wrong value printed by info locals for dynamic object.
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 20 Apr 2010 19:07:18 -0600
- Subject: Re: [RFA/commit/Ada] Wrong value printed by info locals for dynamic object.
- References: <20100420230318.GV19194@adacore.com>
- Reply-to: tromey at redhat dot com
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> return val_print (value_type (val), value_contents_all (val),
>> value_embedded_offset (val), value_address (val),
>> stream, recurse, options, language);
>> Short of creating a language-specific value_contents routine, I think
>> that this was the best/easiest compromise... Thoughts on that?
I suppose a new language method is also possible.
That may be overkill for a single specialization.
Joel> Well, stupid me (again!): I just realized that I checked in a couple
Joel> of patches for which I said yesterday that I'd wait a few days. Sorry
Joel> about that. Hopefully this is not a problem, but I'm happy to revert
Joel> and/or adjust based on feedback. My entire week is dedicated to the
Joel> FSF tree, so I have time...
IMO, don't revert, just address comments if any.
I think reverting should generally be reserved for extreme scenarios,
say when some fundamental problem is discovered.
Tom