Re: [PATCH] gdb: objc-lang: check symbol name before accessing memory

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 19 April 2010 10:55:03 Joel Brobecker wrote:
> > 2010-04-13  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* objc-lang.c (find_methods): Move symname check up.
> 
> This is OK, but I would like you to add a comment before the symbol name
> check explaining that this check is performed first because it can be
> performed entirely without sending any query to the target.

OK

> Can you also confirm how you tested this patch, please?

i'm testing a Blackfin target via gdbserver.  trying to set a breakpoint with 
FDPIC always hit memory_error() before the change while it worked correctly 
after the change.  wrt ObjC, i dont really know anything about the language, 
so i cant really explicitly test that ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.