This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix compilation failure on cygwin due to ncurses macro.


> Thus it should become:
>       /* We need to cast the return value of wstandout to void because
>          in 2009/08/29 patch to release "5.7" of ncurses library,
>          the wstandout macro expands to code that generates a unused-value
>          warning at compilation.  */
> 
> Is this correct?

Sounds right to me - just one nit: I think it's "an unused-value" rather
than "a unused...".

Suggestion (which you are free to ignore): Would it make sense to define
a new function or macro to have the cast (and therefore the comment) in
only one place?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]