This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] disassemble support start,+length format
- From: Tom Tromey <tromey at redhat dot com>
- To: crquan at gmail dot com
- Cc: gdb-patches at sourceware dot org, Hui Zhu <teawater at gmail dot com>, Joel Brobecker <brobecker at adacore dot com>, Eli Zaretskii <eliz at gnu dot org>
- Date: Fri, 09 Apr 2010 12:14:13 -0600
- Subject: Re: [PATCH] disassemble support start,+length format
- References: <1270786615-29934-1-git-send-email-crquan@gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> ">" == crquan <crquan@gmail.com> writes:
>> From: CHENG Renquan <rqcheng@smu.edu.sg>
>> add new support for disassemble by "start,+length" format;
Do you have a copyright assignment in place?
If not, let me know and I can get you started.
>> /* Two arguments. */
>> + int incl_flag = 0;
>> +
>> low = pc;
I think you should skip whitespace here.
>> + if (arg[0] == '+') {
The brace placement is wrong here. See the GNU Coding Standards, or
existing code in that function.
Otherwise this seems reasonable to me.
Tom