This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: "H.J. Lu" <hongjiu dot lu at intel dot com>, GDB <gdb-patches at sourceware dot org>
- Date: Fri, 9 Apr 2010 09:05:18 -0700
- Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE
- References: <20100409155012.GA19118@intel.com> <20100409160208.GP19194@adacore.com>
On Fri, Apr 9, 2010 at 9:02 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> Mark already answered, but I noticed something that was perhaps worth
> a suggestion:
>
>> + ?if (i386_linux_regset_sections[i].sect_name == NULL)
>> + ? ?internal_error (__FILE__, __LINE__,
>> + ? ? ? ? ? ? ? ? _("invalid core regset secion %s"), name);
>
> In this sort of situation (something that should never happen unless
> there is a programming error in GDB), you might prefer the use of
> gdb_assert.
>
I made the change. I am waiting for suggestions before submitting
a new patch.
Thanks.
--
H.J.