This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] disassemble support start,+length format


On Fri, Apr 9, 2010 at 4:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> -* "disassemble" command with a /r modifier, print the raw instructions
>> -in hex as well as in symbolic form.
>> +* The "disassemble" command with an optional /r modifier, print the raw
>> +instructions in hex as well as in symbolic form; optional /m modifier to
>> +print mixed source+assembly.
>
> Thanks. ÂBut please use the style we use in other NEWS entries.
> Something like "The disassemble command now supports ..." etc.

The previous entries in "Changes in GDB 7.0" already have problems, I
should check,

>
>> +arguments specify a range of addresses, in the form of "start,end" or
>> +"start,+length", stand for [start,end) and [start,start+length), (first
>> +inclusive, second exclusive) to dump. ÂIn that case, the name of the
>> +function is also printed (since there could be several functions in the
>> +given range).
>
> I suggest to rephrase as follows:
>
> Âarguments specify a range of addresses to dump, in one of two forms:
>
> Â@table @code
> Â@item @var{start},@var{end}
> Âthe addresses from @var{start} (inclusive) to @var{end} (exclusive)
> Â@item @var{start},+@var{length}
> Âthe addresses from @var{start} (inclusive) to
> Â@code{@var{start}+@var{length}} (exclusive).
> Â@end table
>
> Â@noindent
> ÂWhen 2 arguments are specified, the name of the function is also
> Âprinted (since there could be several functions in the given range).
>
> Note that I used @var{start},@var{end}}, instead of using double
> quotes (which is generally a no-no in Texinfo sources).

OK, I really know little about texinfo writing; Thanks,

-- 
Cheng Renquan (çäå), from Singapore


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]