Re: [RFA] Add -s option to source command.

[Doug Evans <dje at google dot com>]

On Wed, Apr 7, 2010 at 1:14 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> This patch adds a -s option to the source command to make it
> Doug> search for the script in the source search path even if the script
> Doug> name specifies a directory.
>
> It seems reasonable to me.
>
> Doug> ?Read commands from a file named FILE.\n\
> Doug> ?Optional -v switch (before the filename) causes each command in\n\
> Doug> ?FILE to be echoed as it is executed.\n\
> Doug> +Optional -s switch (before the filename) causes gdb to search for\n\
> Doug> +the script in the source search path, even if FILE contains directories.\n\
>
> I often wish that gdb help strings were formatted more like --help
> output.
>
> Tom
>

Something like this?

@@ -1379,8 +1437,12 @@ Commands defined in this way may have up

   source_help_text = xstrprintf (_("\
 Read commands from a file named FILE.\n\
-Optional -v switch (before the filename) causes each command in\n\
-FILE to be echoed as it is executed.\n\
+\n\
+Usage: source [-s] [-v] FILE\n\
+-s: search for the script in the source search path,\n\
+    even if FILE contains directories.\n\
+-v: each command in FILE is echoed as it is executed.\n\
+\n\
 Note that the file \"%s\" is read automatically in this way\n\
 when GDB is started."), gdbinit);
   c = add_cmd ("source", class_support, source_command,

2010-04-08  Doug Evans  <dje@google.com>

	Add -s option to source command.
	* NEWS: Document new option.
	* cli/cli-cmds.c (find_and_open_script): Add function comment.
	Delete from_tty and cleanupp args.  Split filep arg into file and
	full_pathp.  New arg search_path.
	(source_script_from_stream): New function.
	(source_script_with_search): New function.
	(source_script): Rewrite.
	(source_command): Parse "-s" option.
	(init_cli_cmds): Add "-s" docs to source command help, and reformat.
	* python/python.c (source_python_script): Make file arg a const char *.
	Don't call fclose, leave for caller.
	* python/python.h (source_python_script): Update.

	testsuite/
	* gdb.base/source-test.gdb: New file.
	* gdb.base/source.exp: Add tests for "source -s".

	doc/
	* gdb.texinfo (Command Files): Add docs for new "source -s" option.

Attachment: gdb-100408-source-s-2.patch.txt
Description: Text document