This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: fix stack unwind through uClibc syscall() on mips


> 1. Disassembly
> example is below

Thanks - I actually got myself confused as to where the SP adjustment
happened, so it's good to see the assembly.

> 2. copyright assignment
> I was hoping to fall into this category: "Small changes can be
> accepted without a copyright assignment form on file."

Unfortunately, this one is beyond what can be accepted as a small
change (the guideline is 10-15 lines max).

Overall, I don't know mips well enough and I am a little nervous about
the approach you are taking (it feels too general an approach for such
a specific situation).

Hopefully Daniel can give you more insight?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]