This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fix for Go32-v2 native woes


> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Tue, 6 Apr 2010 16:15:05 +0200
> 
>   I finally managed to find a fix, but it is not straightforward:
>   I had to add a new xml file in features/i386 directory
> specific for go32v2 target, that does not read i386-sse.xml.
>   I had to adapt the code in i386-tdep.c to support
> missing feature_vector and to set tdesc to
> tdesc_i386_go32v2 instead of tdesc_i386 when go32v2
> osabi was detected.
> 
>   This allows me to use CVS GDB on DJGPP again.
> 
>   I checked with a testsuite run on gcc-farm that nothing changed
> for at least that other target (amd64-linux).
> 
>   Similar fixes might be required for other 'old'
> i386 targets that do not support SSE registers.
> 
>   Comments welcome as usual!

Thanks.  But I really hope that a much more elegant solution could be
found.  A general layer of code such as i386-tdep.c should not include
any code that is specific to certain targets.

Why do we always read i386-sse.xml or assume that SSE is supported?
We should not assume any CPU features by default if there are CPUs out
there which we support that don't have them.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]