This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] winsock include fixes
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Ozkan Sezer <sezeroz at gmail dot com>
- Cc: gdb-patches at sources dot redhat dot com, ktietz70 at googlemail dot com
- Date: Fri, 26 Mar 2010 10:17:04 -0400
- Subject: Re: [PATCH] winsock include fixes
- References: <647fe9b11003260354o53df5f0ayde8d1e3a03f1b694@mail.gmail.com>
On Fri, Mar 26, 2010 at 12:54:10PM +0200, Ozkan Sezer wrote:
> Hi: Here is a patch fixing the winsock include problem
> which appeared after the recent winsock header work in
> mingw-w64-headers.
This patch isn't OK, because it fixes an inclusion order problem by
moving things around without a comment. Everywhere else the
"gdb_XXX.h" headers are included in a group, last. So someone's going
to clean up these files and reintroduce the problem.
It sounds like part of the problem is the inclusion of winsock2.h in
gdb_select.h, and windows.h in serial.h. Should we include both
headers in both files to avoid the problem?
--
Daniel Jacobowitz
CodeSourcery