[RFA] Java DWARF fixes (was Re: [RFA] dwarf2_physname FINAL)

[Keith Seitz <keiths at redhat dot com>]

On 03/25/2010 03:20 AM, Ulrich Weigand wrote:
> > I should think so... :-) If maintainers wish it so, it will be done.
>
> I'd appreciate that, thanks!

I've appended this to the attached patch.

> > No, it's not. I have a patch for this, but I've noticed some other
> > little java regressions (which are not tested by the test suite), so I
> > am going to delay submitting my patch until I can get the problems all
> > worked out.

My problems turned out to stem from another GCC debuginfo problem, 
described in gcc/43521 (out-of-line debuginfo for class methods does not 
mark "this" ptr with DW_AT_artificial).

I've worked around the issue in the attached patch, which should fix all 
the problems with Java that the dwarf2_physname patch introduced (or at 
least all the problems that anyone has yet noticed :-).

Ok?
Keith

ChangeLog
2010-03-25  Keith Seitz  <keiths@redhat.com>

	* dwarf2read.c (read_subroutine_type): If the compilation unit
	language is Java, mark any formal parameter named "this" as
	artificial (GCC/43521).
	(dwarf2_name): Add special handling for Java constructors.

testsuite/ChangeLog
2010-03-25  Keith Seitz  <keiths@redhat.com>

	* gdb.java/jprint.exp: XFAIL printing of static class members
	because of GCC debuginfo problem.

Attachment: java-dwarf.patch
Description: Text document