This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[obv] Fix spu-tdep.c compilation error [Re: [MI tracepoints 1/9] Simplify MI breakpoint setting]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 17 Mar 2010 14:40:34 +0100
- Subject: [obv] Fix spu-tdep.c compilation error [Re: [MI tracepoints 1/9] Simplify MI breakpoint setting]
- References: <201003141145.40387.vladimir@codesourcery.com>
Hi Vladimir,
with --enable-targets=all there is:
spu-tdep.c: In function ‘spu_catch_start’:
spu-tdep.c:1866: error: implicit declaration of function ‘set_breakpoint’
Checked-in. I do not have SPU to test it but it seems to be [obv] enough.
Thanks,
Jan
Extracted relevant parts of the former change:
# commit 898e66d56b7886f6cd75d6eb8b72f9b91a12309d
# Author: Vladimir Prus <vladimir@codesourcery.com>
# Date: Tue Mar 16 08:42:19 2010 +0000
#
# 2010-03-16 Vladimir Prus <vladimir@codesourcery.com>
#
# Simplify MI breakpoint setting.
#
# * breakpoint.c (break_command_really): Make nonstatic and
# rename to...
# (create_breakpoint): ...this. Rename prior function by this name
# to...
# (create_breakpoint_sal): ...this.
# (create_breakpoints): Rename to...
# (create_breakpoints_sal): ...this.
# (set_breakpoint): Remove.
# * breakpoint.h: Adjust to above changes.
# * mi/mi-cmd-break.c (mi_cmd_break_insert): Simplify.
#
# -static int
# -break_command_really (struct gdbarch *gdbarch,
# - char *arg, char *cond_string, int thread,
# - int parse_condition_and_thread,
# - int tempflag, int hardwareflag, int traceflag,
# - int ignore_count,
# - enum auto_boolean pending_break_support,
# - struct breakpoint_ops *ops,
# - int from_tty,
# - int enabled)
# +int
# +create_breakpoint (struct gdbarch *gdbarch,
# + char *arg, char *cond_string, int thread,
# + int parse_condition_and_thread,
# + int tempflag, int hardwareflag, int traceflag,
# + int ignore_count,
# + enum auto_boolean pending_break_support,
# + struct breakpoint_ops *ops,
# + int from_tty,
# + int enabled)
#
# -void
# -set_breakpoint (struct gdbarch *gdbarch,
# - char *address, char *condition,
# - int hardwareflag, int tempflag,
# - int thread, int ignore_count,
# - int pending, int enabled)
# -{
# - break_command_really (gdbarch,
# - address, condition, thread,
# - 0 /* condition and thread are valid. */,
# - tempflag, hardwareflag, 0 /* traceflag */,
# - ignore_count,
# - pending
# - ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE,
# - NULL, 0, enabled);
# -}
http://sourceware.org/ml/gdb-cvs/2010-03/msg00163.html
--- src/gdb/ChangeLog 2010/03/16 20:51:23 1.11492
+++ src/gdb/ChangeLog 2010/03/17 13:38:54 1.11493
@@ -1,3 +1,8 @@
+2010-03-17 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * spu-tdep.c (spu_catch_start): Replace set_breakpoint call with the
+ create_breakpoint call, adjust the parameters.
+
2010-03-16 Jan Kratochvil <jan.kratochvil@redhat.com>
Chandru <chandru@in.ibm.com>
--- src/gdb/spu-tdep.c 2010/03/09 18:09:07 1.57
+++ src/gdb/spu-tdep.c 2010/03/17 13:38:56 1.58
@@ -1863,11 +1863,13 @@
/* Use a numerical address for the set_breakpoint command to avoid having
the breakpoint re-set incorrectly. */
xsnprintf (buf, sizeof buf, "*%s", core_addr_to_string (pc));
- set_breakpoint (get_objfile_arch (objfile),
- buf, NULL /* condition */,
- 0 /* hardwareflag */, 1 /* tempflag */,
- -1 /* thread */, 0 /* ignore_count */,
- 0 /* pending */, 1 /* enabled */);
+ create_breakpoint (get_objfile_arch (objfile), buf /* arg */,
+ NULL /* cond_string */, -1 /* thread */,
+ 0 /* parse_condition_and_thread */, 1 /* tempflag */,
+ 0 /* hardwareflag */, 0 /* traceflag */,
+ 0 /* ignore_count */,
+ AUTO_BOOLEAN_FALSE /* pending_break_support */,
+ NULL /* ops */, 0 /* from_tty */, 1 /* enabled */);
}