This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 3/5] Prec: x86 segment register support: target


Hui Zhu wrote:
This patch add a interface to let GDB get segment base message from inferior.

Thanks,
Hui

2010-03-16 Hui Zhu <teawater@gmail.com>

	* target.c (update_current_target): Add to_get_segment_base.
	* target.h (target_ops): Ditto.

Hi Hui,


I'm glad you're doing this.

However, isn't target.c the wrong place for this function?
Wouldn't it belong better in the gdbarch?  It is architecture-
specific, if I understand correctly.

That is, this will be the same between i386-ptrace and i386-remote,
but different between i386-remote and (say) mips-remote.

Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]