This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] sim: avoid TRACE redefine warnings

From: Joel Brobecker <brobecker at adacore dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: gdb-patches at sourceware dot org
Date: Tue, 16 Mar 2010 09:06:32 -0700
Subject: Re: [PATCH v2] sim: avoid TRACE redefine warnings
References: <1268599156-23584-1-git-send-email-vapier@gentoo.org> <1268678817-11407-1-git-send-email-vapier@gentoo.org>

> 2010-03-15  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* hw-ports.c (TRACE): Delete.
> 	* hw-properties.c (TRACE): Delete.
> 	(hw_find_ihandle_runtime_property): Change TRACE to HW_TRACE.
> 	(hw_find_integer_property): Likewise.
> 	(hw_find_integer_array_property): Likewise.
> 	(hw_add_duplicate_property): Likewise.

This looks good to me. I don't understand why people use two parentheses
in the call to HW_TRACE:

    HW_TRACE ((me, [...], property))

But it looks like it's the style being used, so OK.

-- 
Joel

Follow-Ups:
- Re: [PATCH v2] sim: avoid TRACE redefine warnings
  - From: Doug Evans

References:
- [PATCH] sim: avoid TRACE redefine warnings
  - From: Mike Frysinger
- [PATCH v2] sim: avoid TRACE redefine warnings
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]