This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] remote-mips.c: Add support for NEC rockhopper boards

> I noticed that several of the other _open functions are missing
> comments describing what they do also.  I was tempted to add those
> comments to this patch too, but decided against it since that would go
> beyond the intended scope of this patch.

Definitely agreed. It's great that you're willing to improve the situation
in this case, but it's only up to you (it would be unfair to ask this
everytime a file is touched...).

-- 
Joel
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]