This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Mon, 8 Mar 2010 16:48:56 -0500
- Subject: Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API
- References: <000901cabeda$3cd7bd00$b6873700$@muller@ics-cnrs.unistra.fr> <20100308200858.GA28304@caradoc.them.org>
On Mon, Mar 08, 2010 at 03:09:04PM -0500, Daniel Jacobowitz wrote:
>On Mon, Mar 08, 2010 at 05:13:06PM +0100, Pierre Muller wrote:
>> http://sourceware.org/ml/gdb-patches/2010-03/msg00101.html
>>
>> In order to complete the fix for 1.5 Cygwin API,
>> we need to fix the compilation failure in
>> remote-fileio.c source.
>>
>> Christopher said in a previous email that he
>> didn't have an opinion about that part.
>> http://sourceware.org/ml/gdb-patches/2010-03/msg00260.html
>>
>> I do not really know if there is a specific maintainer for this
>> file... Could someone (a global maintainr?)
>> please review this patch?
>
>This is OK.
Sorry, I guess I was wrong about the opinion. I do have a mild one.
While I said I didn't have an opinion about this, wouldn't it really
make sense to use the same mechanism that I adopted for windows-nat.c?
cgf