This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds


>>>>> "Corinna" == Corinna Vinschen <vinschen@redhat.com> writes:

Corinna> +void
Corinna> +set_auto_target_wide_charset (char *charset)

Argument should be const.

Corinna> +void
Corinna> +set_auto_target_charset (char *charset)

Likewise.

I think the documentation for these functions (in charset.h) should
mention the expected lifetime of the arguments.

Corinna> @@ -874,7 +917,7 @@ _initialize_charset (void)
[...]
Corinna> +  auto_target_charset_name = auto_host_charset_name;
 
Corinna>  _initialize_windows_nat (void)
[...]
Corinna> +  set_auto_target_charset ("UTF-8");

This seems to introduce an ordering dependency between _initialize
functions.  My understanding is that we don't allow this.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]