This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Add namespace aliasing support.
- From: Doug Evans <dje at google dot com>
- To: tromey at redhat dot com, Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 8 Feb 2010 16:38:26 -0800
- Subject: Re: [patch] Add namespace aliasing support.
- References: <4B630D3F.8010507@redhat.com> <m3y6jg7ja6.fsf@fleche.redhat.com> <4B673929.9040900@redhat.com> <m3bpg71lyc.fsf@fleche.redhat.com>
On Tue, Feb 2, 2010 at 11:23 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
>
> Sami> 2010-02-01 ?Sami Wagiaalla ?<swagiaal@redhat.com>
> Sami> ? ?* cp-support.h: Added char* alias element to using_direct data
> Sami> ? ?struct.
>
> I noticed that an earlier ChangeLog entry of yours (in testsuite) had 4
> leading spaces rather than a tab. ?This one seems to have the same
> problem, at least if you cut-and-pasted it; please fix before
> committing.
>
> Also, put the PR number into the ChangeLog entry and the commit. ?You
> can see the existing ChangeLog for some examples of the formatting.
> Putting it in the ChangeLog just makes the entry a little more useful;
> putting it into the commit message will make some info about the commit
> be automatically appended to the PR.
>
> Sami> + ? scope. ?If ALIAS is an empty string then the namespace is known by its
> Sami> + ? original name.
>
> This should say something like: ?If ALIAS is not null, then ...
>
> Sami> + ? of the list. ?ALIAS is set to a non empty string if the imported namespace
> Sami> + ? has been aliased.
>
> Likewise.
>
> This patch is ok with those things fixed. ?Thanks.
>
> Tom
>
Sorry for coming into this late. NEWS entry?
[I mention it because I find the NEWS file really useful.]