This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Revised pr 9067 patch
- From: Tom Tromey <tromey at redhat dot com>
- To: Chris Moller <cmoller at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 03 Feb 2010 15:21:30 -0700
- Subject: Re: Revised pr 9067 patch
- References: <4B69D837.8080501@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Chris" == Chris Moller <cmoller@redhat.com> writes:
Chris> Fixes "Nested static causing infinite recursion in print."
There are still the formatting nits that I mentioned on the last
go-round.
Chris> + void * statmem_obstack_top = NULL;
No space after *.
Chris> + /* set the current printed-statics stack top */
Comments in the GNU style are sentences. They start with a capital
letter and end with a period and two spaces.
Chris> + /* In effect, a pop of the printed-statics stack */
Ditto.
Chris> + first_dont_print = (CORE_ADDR *)obstack_base (&dont_print_statmem_obstack);
Line goes past column 79? It seems to but sometimes it is hard to tell
in a patch. Space after the closing paren of the cast.
Chris> + i = obstack_object_size (&dont_print_statmem_obstack) / sizeof(CORE_ADDR);
Space after sizeof. Too many columns, should line break.
Tom