This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: add sym_relocate method to sym_fns


On Jan 29, 2010, at 8:04 PM, Tom Tromey wrote:

>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
> 
> Tristan> This first patch just adds this method but uses the default
> Tristan> implementation, so this is a no-op.  The interface is also
> Tristan> slightly modified: the first argument is the objfile instead of
> Tristan> its bfd.
> 
> Seems reasonable.
> 
> Tristan> +/* Default implementation for sym_relocate.  */
> Tristan> +
> Tristan> +bfd_byte *
> Tristan> +symfile_relocate_debug_section (struct objfile *objfile,
> Tristan> +                                asection *sectp, bfd_byte *buf)
> 
> I think this comment is misplaced and belongs on the previous function
> instead.
> 
> Tristan> +  return (*objfile->sf->sym_relocate)(objfile, sectp, buf);
> 
> Space after the first closing paren.
> 
> Ok with those nits fixed, thanks.

Thank you for your review.  Committed with these nits fixed.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]