This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA]: add sym_relocate method to sym_fns
- From: Tristan Gingold <gingold at adacore dot com>
- To: tromey at redhat dot com
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Wed, 3 Feb 2010 15:21:23 +0100
- Subject: Re: [RFA]: add sym_relocate method to sym_fns
- References: <89835999-77F3-4D3A-BF16-F790560A336B@adacore.com> <m37hr091i6.fsf@fleche.redhat.com>
On Jan 29, 2010, at 8:04 PM, Tom Tromey wrote:
>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
>
> Tristan> This first patch just adds this method but uses the default
> Tristan> implementation, so this is a no-op. The interface is also
> Tristan> slightly modified: the first argument is the objfile instead of
> Tristan> its bfd.
>
> Seems reasonable.
>
> Tristan> +/* Default implementation for sym_relocate. */
> Tristan> +
> Tristan> +bfd_byte *
> Tristan> +symfile_relocate_debug_section (struct objfile *objfile,
> Tristan> + asection *sectp, bfd_byte *buf)
>
> I think this comment is misplaced and belongs on the previous function
> instead.
>
> Tristan> + return (*objfile->sf->sym_relocate)(objfile, sectp, buf);
>
> Space after the first closing paren.
>
> Ok with those nits fixed, thanks.
Thank you for your review. Committed with these nits fixed.
Tristan.