This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Fix build for GO32 and WIN32 targets


On Thursday 21 January 2010 18:00:38, Eli Zaretskii wrote:
> > Date: Thu, 21 Jan 2010 15:12:35 +0100
> > From: Kai Tietz <ktietz70@googlemail.com>
> > 
> > Hello,
> > 
> > the function check_syscall in file inflow.c is static, but isn't used
> > for GO32 and _WIN32 targets. So this leads to "defined but not used"
> > warning and breaks build. Patch fix this
> 
> I don't understand.  How come all other ports don't hit the same
> problem?  AFAIK, this feature is not yet implemented on all of them.
> What am I missing?

Reading the code? ;-)  All the callers of check_syscall are
wrapped inside:

 #if !defined(__GO32__) && !defined(_WIN32)

The warning is now triggering because we've recently started
building gdb with -Wunused-function.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]