This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 10/15] PIE: testcase: Test also shared libraries


On Tue, 10 Nov 2009 22:26:28 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> gdb/testsuite/
> Jan> 	* gdb.base/break-interp-main.c, gdb.base/break-interp-lib.c: New.
> Jan> 	* gdb.base/break-interp.exp: Exit on skip_shlib_tests.  Change $srcfile.
> Jan> 	New variables $binfile_lib and $srcfile_lib.  Call get_compiler_info
> Jan> 	and gdb_compile_shlib.  Use new -Wl compiler options.
> Jan> 	(dl bt, main bt): New tests.
> 
> Ok.

Checked-in.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-01/msg00122.html

--- src/gdb/testsuite/ChangeLog	2010/01/14 21:01:25	1.2084
+++ src/gdb/testsuite/ChangeLog	2010/01/14 21:04:52	1.2085
@@ -1,5 +1,13 @@
 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* gdb.base/break-interp-main.c, gdb.base/break-interp-lib.c: New.
+	* gdb.base/break-interp.exp: Exit on skip_shlib_tests.  Change $srcfile.
+	New variables $binfile_lib and $srcfile_lib.  Call get_compiler_info
+	and gdb_compile_shlib.  Use new -Wl compiler options.
+	(dl bt, main bt): New tests.
+
+2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	Support PIEs with no symfile_objfile.
 	* gdb.base/break-interp.exp: New argument at the test_ld calls.
 	(test_ld): New parameter trynosym.
--- src/gdb/testsuite/gdb.base/break-interp-lib.c
+++ src/gdb/testsuite/gdb.base/break-interp-lib.c	2010-01-14 21:05:02.622154000 +0000
@@ -0,0 +1,24 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2009 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <signal.h>
+
+void
+libfunc (void)
+{
+  raise (SIGSEGV);
+}
--- src/gdb/testsuite/gdb.base/break-interp-main.c
+++ src/gdb/testsuite/gdb.base/break-interp-main.c	2010-01-14 21:05:04.829234000 +0000
@@ -0,0 +1,26 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2009 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+extern void libfunc (void);
+
+int
+main (void)
+{
+  libfunc ();
+
+  return 0;
+}
--- src/gdb/testsuite/gdb.base/break-interp.exp	2010/01/14 21:01:25	1.2
+++ src/gdb/testsuite/gdb.base/break-interp.exp	2010/01/14 21:04:53	1.3
@@ -14,7 +14,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 # This test only works on GNU/Linux.
-if { ![isnative] || [is_remote host] || ![istarget *-linux*] } {
+if { ![isnative] || [is_remote host] || ![istarget *-linux*] || [skip_shlib_tests]} {
     continue
 }
 
@@ -23,7 +23,21 @@
 # Only to get the $interp_system name.
 set srcfile_test "start.c"
 set binfile_test ${test}-test
-set srcfile "start.c"
+set binfile_lib ${objdir}/${subdir}/${test}.so
+set srcfile "${test}-main.c"
+set srcfile_lib "${test}-lib.c"
+
+if [get_compiler_info ${binfile_lib}] {
+    return -1
+}
+
+# Use -soname so that it is listed with " => " by ldd and this testcase makes
+# a copy of ${binfile_lib} for each prelink variant.
+
+if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} [list debug additional_flags=-Wl,-soname,${test}.so]] != ""} {
+    return -1
+}
+
 if {[build_executable ${test}.exp $binfile_test ${srcfile_test} {}] == -1} {
     return -1
 }
@@ -236,8 +250,15 @@
     gdb_load $file
 
     reach "dl_main" run
+
+    gdb_test "bt" "#0 +\[^\r\n\]*\\mdl_main\\M.*" "dl bt"
+
     if $ifmain {
 	reach "main" continue
+
+	reach "libfunc" continue
+
+	gdb_test "bt" "#0 +\[^\r\n\]*\\mlibfunc\\M\[^\r\n\]*\r\n#1 +\[^\r\n\]*\\mmain\\M.*" "main bt"
     }
 
     if !$trynosym {
@@ -389,6 +410,7 @@
 		    lappend pf_prefix "$binname:"
 
 		    set opts "additional_flags=-Wl,--dynamic-linker,$interp,-rpath,$dir"
+		    lappend opts "additional_flags=-Wl,$binfile_lib,-rpath,[file dirname $binfile_lib]"
 		    if {$binsepdebug != "NO"} {
 			lappend opts {debug}
 		    }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]