This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 04/15] PIE: Add from_tty to solib_create_inferior_hook


On Tue, 10 Nov 2009 19:00:51 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> SOLIB_CREATE_INFERIOR_HOOK was not modified as its only called
> Jan> xcoff_relocate_symtab has no use for FROM_TTY.
> 
> It would be nice to nuke SOLIB_CREATE_INFERIOR_HOOK, given that there is
> just a single definition.

OK; not resolved now.


> Jan> 	* infcmd.c (post_create_inferior): Move solib_add after
> Jan> 	solib_create_inferior_hook.  Pass from_tty to
> Jan> 	solib_create_inferior_hook.  Call solib_add and SOLIB_ADD with
> Jan> 	0 from_tty and comment why.
> [...]
> 
> Ok.

Checked-in in its original form:
	http://sourceware.org/ml/gdb-cvs/2010-01/msg00067.html

Regression retested on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]