This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Support the new BookE ptrace interface
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Luis Machado <luisgpm at linux dot vnet dot ibm dot com>, Matt Tyrlik <tyrlik at us dot ibm dot com>
- Date: Tue, 5 Jan 2010 08:51:30 +0400
- Subject: Re: [PATCH 1/4] Support the new BookE ptrace interface
- References: <200912232230.56227.bauerman@br.ibm.com> <200912311518.14325.bauerman@br.ibm.com>
> 2009-12-31 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
> Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> * ppc-linux-nat.c (PTRACE_GET_DEBUGREG): Update comment.
> (PPC_PTRACE_GETWDBGINFO, PPC_PTRACE_SETHWDEBUG, PPC_PTRACE_DELHWDEBUG,
> ppc_debug_info, PPC_DEBUG_FEATURE_INSN_BP_RANGE,
> PPC_DEBUG_FEATURE_INSN_BP_MASK, PPC_DEBUG_FEATURE_DATA_BP_RANGE,
> PPC_DEBUG_FEATURE_DATA_BP_MASK, ppc_hw_breakpoint,
> PPC_BREAKPOINT_TRIGGER_EXECUTE, PPC_BREAKPOINT_TRIGGER READ,
> PPC_BREAKPOINT_TRIGGER_WRITE, PPC_BREAKPOINT_TRIGGER_RW,
> PPC_BREAKPOINT_MODE_EXACT PPC_BREAKPOINT_MODE_RANGE_INCLUSIVE,
> PPC_BREAKPOINT_MODE_RANGE_EXCLUSIVE, PPC_BREAKPOINT_MODE_MASK,
> PPC_BREAKPOINT_CONDITION_NONE, PPC_BREAKPOINT_CONDITION_AND,
> PPC_BREAKPOINT_CONDITION_EXACT, PPC_BREAKPOINT_CONDITION_OR,
> PPC_BREAKPOINT_CONDITION_AND_OR, PPC_BREAKPOINT_CONDITION_BE_ALL,
> PPC_BREAKPOINT_CONDITION_BE_SHIFT, PPC_BREAKPOINT_CONDITION_BE):
> Define, in case <ptrace.h> doesn't provide it.
> (have_ptrace_new_debug_booke): New global.
> (ppc_linux_check_watch_resources): Renamed to ...
> (ppc_linux_can_use_hw_breakpoint): ... this. Handle BookE processors.
> (booke_debug_info): New variable.
> (max_slots_number): Ditto.
> (hw_break_tuple): New struct.
> (thread_points): Ditto.
> (ppc_threads): New variable.
> (PPC_DEBUG_CURRENT_VERSION): New define.
> (ppc_linux_region_ok_for_hw_watchpoint): Handle BookE processors.
> (booke_cmp_hw_point): New function.
> (booke_find_thread_points_by_tid): Ditto.
> (booke_insert_point): Ditto.
> (booke_remove_point): Ditto.
> (ppc_linux_insert_hw_breakpoint): Ditto.
> (ppc_linux_remove_hw_breakpoint): Ditto.
> (ppc_linux_insert_watchpoint): Handle BookE processors.
> (ppc_linux_remove_watchpoint): Ditto.
> (ppc_linux_new_thread): Ditto.
> (ppc_linux_stopped_data_address): Ditto.
> (ppc_linux_watchpoint_addr_within_range): Ditto.
> (ppc_linux_read_description): Query the target to know if it
> supports the new kernel BookE interface.
> (_initialize_ppc_linux_nat): Initialize to_insert_hw_breakpoint and
> to_remove_hw_breakpoint fields of the target operations struct.
Still looks good to me :). Just a couple of nits, but otherwise approved.
It would still be nice if Ulrich had a chance to take a quick look ;-).
> +struct ppc_debug_info {
> + uint32_t version; /* Only version 1 exists to date */
The curly brace should be at the beginning of the next line.
And the indentation (probably a copy-paste from the kernel headers?)
needs to be adjusted.
Not that it really matters a whole lot. For this section, if it makes
things simpler to preserve the indentation of the original, I could
be convinced to leave the code untouched.
> +static int get_trigger_type (int rw)
Formatting nit as well:
static int
get_trigger_type (int rw)
--
Joel