This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB MI Reverse Commands added [3 of 3]
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Jakob Engblom <jakob at virtutech dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 16 Dec 2009 11:06:12 +0300
- Subject: Re: GDB MI Reverse Commands added [3 of 3]
- References: <00d001ca265a$ddd0c800$99725800$@com> <4B27E619.8080607@vmware.com>
On Tuesday 15 December 2009 22:40:09 Michael Snyder wrote:
> Jakob Engblom wrote:
> > Final part: the test suite for gdb-MI reverse debugging commands. Attached as a
> > file, to be put in [gdb]/src/gdb/testsuite/gdb.mi/
> >
> > Best regards,
> >
> > /jakob
>
> Part 3, test suite.
I do not have any further comments relative to those in:
http://article.gmane.org/gmane.comp.gdb.patches/51523/
It does not seem like any of them were addressed. When they are addressed,
this patch is OK. Because the only non-mechanical change is replacement of
FIXME with a suitable comment, and reverse-mode experts are in much better
position to decide if a comment captures the behaviour properly, I don't
think I have to re-review any revision of this patch -- please commit directly
when you think it's ready.
- Volodya