This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix for PR gdb/11022
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 2 Dec 2009 11:37:08 -0800
- Subject: Re: [patch] Fix for PR gdb/11022
- References: <20091125234600.8128276D99@ppluzhnikov.mtv.corp.google.com> <20091126212111.GB18125@adacore.com>
On Thu, Nov 26, 2009 at 1:21 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> PR gdb/11022
>>
>> * breakpoint.c (invalidate_bp_value_on_memory_change):
>> New function.
>> (_initialize_breakpoint): Add it as memory change observer.
>
> Seems fine to me, but I have become more and more unfamiliar with
> this area, not having been involved with it for a while. So let's wait
> a week or so to see if anyone has any comment, and then it can go in.
I'll commit this later today, if there are no other comments.
>> + j = 0; // break here
> Can you use C-style comments, here (since this is a C file)?
With the C-style comment correction.
Thanks,
--
Paul Pluzhnikov